cpu: x64: xbyak: update third-party xbyak to v7.37#5082
Open
georgen117 wants to merge 1 commit intorls-v3.12from
Open
cpu: x64: xbyak: update third-party xbyak to v7.37#5082georgen117 wants to merge 1 commit intorls-v3.12from
georgen117 wants to merge 1 commit intorls-v3.12from
Conversation
Contributor
Author
|
make test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #5081
x64: cpu: xbyak: update third-party xbyak to v7.37
Resolves MFDNN-14982
Overview
Updates the oneDNN vendored copy of Xbyak from v7.35.4 to v7.37. The update is applied as a cherry-picked diff on top of the existing oneDNN-specific modifications (Intel copyright headers, etc.) so all local changes are preserved.
xbyak_bin2hex.his unchanged between the two versions.Changes included in this update
xbyak.h
XBYAK64_WIN/XBYAK64_GCCexternally before including the header (guard the auto-detection with#if !defined(...)).VERSIONconstant to0x7370.sysconf(_SC_PAGESIZE)call withinner::getPageSize()insetProtectModeRWfor consistency with the rest of the codebase.xbyak_mnemonic.h
getVersionString()return value to"7.37".prefetchwt1,v4fmaddps,v4fmaddss,v4fnmaddps,v4fnmaddss,vp4dpwssd,vp4dpwssds.xbyak_util.h
<sched.h>on non-Windows platforms.tAVX512PF,tAVX512ER,tAVX512_4VNNIW,tAVX512_4FMAPS,tPREFETCHWT1) and remove their CPUID detection.tAMX_COMPLEXdetection (AMX-COMPLEX, CPUID leaf 7 sub-leaf 1 EDX[8]).getCoreType()using CPUID leaf 0x1A as a fallback for P-core/E-core detection on hybrid CPUs.XBYAK_WINSDK_HAS_*versioning macros so the code compiles correctly across a range of Windows SDK versions (pre-Win7, Win7+, Win10+, Win10 20H1+). Undefine macros after use to avoid pollution.getCoreTypeForAffinity()for hybrid core-type detection on SDKs that lackEfficiencyClass.convertMask()to work with both the oldGroupMaskfield and the newerGroupMasks[]array.setAffinityAndGetCoreType()helper for hybrid detection.StackFrame/AutoSaveregister allocation with aRegSlot-based table that correctly handles the Windows and Linux calling conventions, fixing register backup/restore order andrspreference in the frame epilogue.oneDNN specific comments on update
For oneDNN the important part of the update is the addition of the Windows SDK versioning macros. This addresses the build failure reported MFDNN-14982 when trying to build oneDNN with an older Windows SDK.
Xbyak has depricated support for Xeon Phi. This resulted in the removal of several mnemonic instructions:
prefetchwt1, fourv4f[n]madd{p|s}sinstructions, and twovp4dpwssd[s]instructions. None of these instructions are used by oneDNN so there deprication does not affect oneDNN. It also resulted in removal of the detection of CPUID features:tAVX512PF,tAVX512ER,tAVX512_4VNNIW,tAVX512_4FMAPS, andtPREFETCHWT1. I was unable to find a single instance of oneDNN checking for the Xeon Phi CPUID features.The
StackFramecode found inxbyak_util.his not used by oneDNN so the updates to that code does not affect oneDNN.Testing