Conversation
github-actions
Bot
added
the
platform:gpu-intel
rjoursler
force-pushed
the
rjoursle/remove_punning
branch
3 times, most recently
from
e7580e5 to
ac6c830
Compare
Contributor
Author
|
make test |
echeresh
approved these changes
Apr 22, 2026
atkassen
approved these changes
Apr 22, 2026
rjoursler
force-pushed
the
rjoursle/remove_punning
branch
5 times, most recently
from
547e732 to
2294e07
Compare
Contributor
Author
|
make test |
This prevents mixing punning/non-punning APIs causing incorrect kernel generation. Additionally fixes the following existing errors: benchdnn --mode-modifier=P --global-impl=ocl --engine=gpu --bnorm --dt=bf16 --tag=axb ic32iw32n benchdnn --mode-modifier=P --global-impl=ocl --engine=gpu --softmax --ddt=bf16 16x16 benchdnn --mode-modifier=P --global-impl=ocl --engine=gpu --prelu --dir=BWD_DW --sdt=bf16:bf16 --stag=axb:any 4x16x3x4:1x1x1x1 benchdnn --mode-modifier=P --global-impl=ocl --engine=gpu --binary --sdt=bf16:bf16 --ddt=bf16 15x12x3x5:1x1x1x1 benchdnn --mode-modifier=P --global-impl=ocl --engine=gpu --binary --sdt=bf16:bf16 --ddt=bf16 --alg=min --inplace=true 3x5x6x9:3x5x6x9
rjoursler
force-pushed
the
rjoursle/remove_punning
branch
from
2294e07 to
7708ca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MFDNN-14925, we found multiple primitive failure due to inconsistent use of WITH_PUNNING across buffers. This PR completely removes this knob so that this failure mode can no longer occur. This fixes MFDNN-14925 along with a few other existing issues I found during testing.