Skip to content

graph: backend: dnnl: exec: gated_mlp uses unique_ptr instead of raw ptr#5060

Open
TaoLv wants to merge 3 commits intomainfrom
lvtao/main/fix-gated-mlp-exec
Open

graph: backend: dnnl: exec: gated_mlp uses unique_ptr instead of raw ptr#5060
TaoLv wants to merge 3 commits intomainfrom
lvtao/main/fix-gated-mlp-exec

Conversation

@TaoLv
Copy link
Copy Markdown
Contributor

@TaoLv TaoLv commented Apr 21, 2026

  1. Similar to what was discussed at graph: backend: dnnl: executables: call internal sdpa iface #4839 (comment), here we also apply the unique_ptr changes to gated_mlp code.
  2. Add is_initialized() function to all executables as we have more and more subclasses need to check the initialization status. It simplifies the code logic in compiles_ops by avoiding per op kind checks.

@TaoLv TaoLv requested a review from a team as a code owner April 21, 2026 02:51
@github-actions github-actions Bot added the component:graph-api Codeowner: @oneapi-src/onednn-graph label Apr 21, 2026
@TaoLv TaoLv force-pushed the lvtao/main/fix-gated-mlp-exec branch 2 times, most recently from b55d41a to 7e89f8a Compare April 21, 2026 03:53
@TaoLv
Copy link
Copy Markdown
Contributor Author

TaoLv commented Apr 21, 2026

make test
disable benchdnn_all
enable benchdnn_graph

Comment thread src/graph/backend/dnnl/executables/batch_norm.hpp
@TaoLv TaoLv force-pushed the lvtao/main/fix-gated-mlp-exec branch from 7e89f8a to ed1963d Compare April 27, 2026 02:26
@TaoLv
Copy link
Copy Markdown
Contributor Author

TaoLv commented Apr 27, 2026

make test
disable benchdnn_all
enable benchdnn_graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:graph-api Codeowner: @oneapi-src/onednn-graph

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants