graph: backend: dnnl: exec: gated_mlp uses unique_ptr instead of raw ptr#5060
Open
graph: backend: dnnl: exec: gated_mlp uses unique_ptr instead of raw ptr#5060
Conversation
b55d41a to
7e89f8a
Compare
Contributor
Author
|
make test |
ElaineBao
approved these changes
Apr 21, 2026
rongzha1
approved these changes
Apr 21, 2026
7e89f8a to
ed1963d
Compare
Contributor
Author
|
make test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unique_ptrchanges to gated_mlp code.is_initialized()function to all executables as we have more and more subclasses need to check the initialization status. It simplifies the code logic incompiles_opsby avoiding per op kind checks.